Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26516] Android: Always set analytics meta #10423

Merged
merged 1 commit into from Nov 6, 2018
Merged

[TIMOB-26516] Android: Always set analytics meta #10423

merged 1 commit into from Nov 6, 2018

Conversation

garymathews
Copy link
Contributor

  • Always set analytics meta data
TEST CASE
Ti.API.info('Ti.Platform.id: ' + Ti.Platform.id);
Ti.API.info('Ti.Platform.version: ' + Ti.Platform.version);

JIRA Ticket

@garymathews garymathews mentioned this pull request Nov 6, 2018
Merged
@build
Copy link
Contributor

build commented Nov 6, 2018

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy added this to the 8.0.0 milestone Nov 6, 2018
@sgtcoolguy sgtcoolguy self-requested a review November 6, 2018 16:47
sgtcoolguy
sgtcoolguy approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy merged commit eae8b59 into tidev:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@jquick-axway jquick-axway Awaiting requested review from jquick-axway

Assignees
No one assigned
Labels
android bug needs tests 🚨
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @sgtcoolguy