Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_5_X][TIMOB-26516] Android: Fix initializing of APSAnalytics.machineId #10430

Merged
merged 2 commits into from Nov 7, 2018
Merged

[7_5_X][TIMOB-26516] Android: Fix initializing of APSAnalytics.machineId #10430

merged 2 commits into from Nov 7, 2018

Conversation

garymathews
Copy link
Contributor

@build
Copy link
Contributor

build commented Nov 6, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

Studio Ver: 5.1.1.201809051655
SDK Ver: 7.5.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.7
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.2
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Pixel (Android 9)
Emulator: ⇨ Android 4.1.2

@lokeshchdhry
Copy link
Contributor

@garymathews , Danger is asking for unit tests.

@garymathews garymathews added this to the 7.5.0 milestone Nov 6, 2018
@lokeshchdhry lokeshchdhry merged commit 61435f0 into tidev:7_5_X Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @lokeshchdhry