[TIMOB-26370] Android: "Failed to create external storage directory" when download image and save to camera roll #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
FR Passed. Image saved |
|
PR Merged |
vijaysingh-axway
pushed a commit
to vijaysingh-axway/titanium_mobile
that referenced
this pull request
Nov 22, 2018
build
pushed a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26370
Description:
WRITE_EXTERNAL_STORAGEadded in Media module where onlyREAD_EXTERNAL_STORAGEis requested. This is in order to make up for a fix in Android 8 which no more grants the whole permission group when a single one is requested.No unit tests for this PR.
Test case:
There is a good test code in the JIRA ticket.