[TIMOB-26533] Ti.Media.Audio player without url set is crashing while registering for event listener #10457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while registering for event listener
Generated by 🚫 dangerJS |
ssjsamir
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
FR PassedTi.Media.Audio player without url set no longer crashes while registering for event listener.
Test Steps:
- Created a new SDK build from this PR
- Created a new titanium application
- Added the test case from https://jira.appcelerator.org/browse/TIMOB-26533 in to the app.js
- Ran the program
- Pressed play
- Application played stream without any issues
Test Environment
APPC Studio: 5.1.0.201808080937
iPhone 6 Sim (iOS 12.1)
APPC CLI: 7.0.6
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.1
Node.js Version: 8.9.1
Xcode 10.0
Awaiting CR
janvennemann
changed the title
janvennemann
approved these changes
Nov 13, 2018
build
pushed a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Dec 3, 2018
… registering for event listener (tidev#10457) * [TIMOB-26533]: iOS Ti.Media.Audio player without url set is crashing while registering for event listener * linting issue fixed * [TIMOB-26533] : TiMediaPlayerProxy.m added to compile source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26533