fix(android): Only remove x86 from valid abis if user does not specify abi tag #10458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we want this in 7.5.0 GA, we'll need to cherry-pick back to 7_5_X |
…y abi tag Fixes TIMOB-26548
ewanharris
force-pushed
the
TIMOB-26548
branch
from
4cf4af7
to
0c0e90f
Compare
|
@ewanharris , The build fails. Can you please take a look. Thanks. |
|
FR Passed. x86 can be specified as an abi for production builds. Studio Ver: 5.1.2.201810301430 |
Generated by 🚫 dangerJS |
build
pushed a commit
to hansemannn/titanium_mobile
that referenced
this pull request
Dec 3, 2018
…y abi tag (tidev#10458) Fixes TIMOB-26548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26548
We should let a user target x86 if they want to. Just want to call out that the change that caused this bug should have been done in a semver major release.
Test steps: See jira