[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecated property get/set methods #10464

jquick-axway · 2018-11-14T03:49:46Z

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26556

Test:

Create a Classic Titanium app via "Default Project" template.
Build and run on Android or iOS.
Verify that neither of the following warning messages get logged.

Automatic getter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 9.0.0. Please access the property in standard JS style...
Automatic setter methods for properties are deprecated in SDK 8.0.0 and will be removed in SDK 9.0.0. Please access the property in standard JS style...

…ed property get/set methods

build · 2018-11-14T04:11:51Z

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

sgtcoolguy

LGTM

[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecat…

a16e715

…ed property get/set methods

jquick-axway added ios android windows improvement no tests labels Nov 14, 2018

jquick-axway requested a review from sgtcoolguy November 14, 2018 03:49

sgtcoolguy approved these changes Nov 15, 2018

View reviewed changes

sgtcoolguy merged commit 8dbe9f8 into tidev:master Nov 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecated property get/set methods #10464

[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecated property get/set methods #10464

jquick-axway commented Nov 14, 2018

build commented Nov 14, 2018

sgtcoolguy left a comment

[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecated property get/set methods #10464

[TIMOB-26556] TiAPI: Modified SDK's core JS files to not use deprecated property get/set methods #10464

Conversation

jquick-axway commented Nov 14, 2018

build commented Nov 14, 2018

sgtcoolguy left a comment

Choose a reason for hiding this comment