Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26580] Android: Fix ListView template support for native modules #10479

Merged
merged 5 commits into from Nov 28, 2018
Merged

[TIMOB-26580] Android: Fix ListView template support for native modules #10479

merged 5 commits into from Nov 28, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Nov 16, 2018 •
edited by lokeshchdhry

  • Fix missing assignment to support native modules

JIRA Ticket

@garymathews garymathews added this to the 8.0.0 milestone Nov 16, 2018
@build
Copy link
Contributor

build commented Nov 16, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@m1ga
Copy link
Contributor

m1ga commented Nov 18, 2018

This still crashes with Error: Requested module not found: /alloy/widgets/AvImageview.ImageView/controllers/widget if you use <ImageView bindId="image" class="profil_img" ns="AvImageview"/> . The old listview.js (https://github.com/appcelerator/titanium_mobile/pull/9955/files#diff-d91f84ce1f8aba65f9302707f8d4c438L83) works fine

ypbnv
ypbnv approved these changes Nov 21, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Sorry for the late review!

@hansemannn
Copy link
Collaborator

Can this be backported to 7.5.1? I think many apps are currency broken and unable to update to 7.5.0 without this.

@lokeshchdhry
Copy link
Contributor

FR Passed.

Use of native modules with listview works fine.

Studio Ver: 5.1.2.201810301430
SDK Ver: 8.0.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.8
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.4
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Nexus 6P (Android 8.1.0)

@lokeshchdhry lokeshchdhry merged commit 3f1e5a1 into tidev:master Nov 28, 2018
build pushed a commit to hansemannn/titanium_mobile that referenced this pull request Dec 3, 2018
@garymathews @sgtcoolguy
[TIMOB-26580] Fix ListView template support for native modules (tidev…
4104ae2 
…#10479)
@AhmedMSayed
Copy link
Contributor

Can this be backported to 7.5.1? I think many apps are currency broken and unable to update to 7.5.0 without this.

Yes, we can't update to 7.5.0 because of this

@garymathews garymathews mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@garymathews @build @m1ga @hansemannn @lokeshchdhry @AhmedMSayed @ypbnv