Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): avoid leaking objects in hasProperty callback (7_5_X) #10525

Merged
merged 7 commits into from Dec 12, 2018
Merged

fix(ios): avoid leaking objects in hasProperty callback (7_5_X) #10525

merged 7 commits into from Dec 12, 2018

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann added this to the 7.5.1 milestone Dec 10, 2018
@build
Copy link
Contributor

build commented Dec 10, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

sgtcoolguy
sgtcoolguy approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback as original change, code looks OK, I'd just prefer we add tests to our suite to verify it.

@lokeshchdhry lokeshchdhry merged commit 639c9e6 into tidev:7_5_X Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug ios
Projects
None yet
Milestone
7.5.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janvennemann @build @sgtcoolguy @hansemannn @lokeshchdhry