Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios) : defaultLocale call should not write currentlocale in userdefault #10545

Merged
merged 1 commit into from Dec 18, 2018

Conversation

vijaysingh-axway
Copy link
Contributor

@build
Copy link
Contributor

build commented Dec 18, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@longton95 longton95 self-requested a review December 18, 2018 14:52
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed

Language and Locales are correct when language and region is changed

Test case:

var win = Ti.UI.createWindow({
    backgroundColor: '#fff'
});

var btn = Ti.UI.createButton({
    title: 'Trigger'
});

var label = Ti.UI.createLabel({
    text: 'Sup',
    top: 100,
    color: 'black'
});

btn.addEventListener('click', function () {
    Ti.API.info(Ti.Locale.currentLanguage);
    Ti.API.info(Ti.Locale.currentLocale);
    label.text = 'Current language: ' + Ti.Locale.currentLanguage + ' Locale: ' + Ti.Locale.currentLocale;

});

win.add(btn);
win.add(label);
win.open();

ENV

iPhone 7 Sim (iOS 12.1)
APPC CLI: 7.0.9-3
MacOS: 10.14.2
Node.js Version: 8.12.0
Xcode 10.1

@longton95 longton95 merged commit f5fdf88 into tidev:7_5_X Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants