feat(iOS): enable dampingRatio and springVelocity #10564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brianggalvez
changed the title
Tests:
|
…m_mobile into TIMOB-18421 * 'TIMOB-18421' of https://github.com/Brianggalvez/titanium_mobile: chore(package): update lockfile package-lock.json fix(package): update temp to version 0.9.0 chore(package): update lockfile package-lock.json chore(package): update @seadub/danger-plugin-dependencies to version 0.1.0 refactor(android): add TiDimension constructor taking in units explicitly
|
@Brianggalvez Thanks for PR. Can you please fix the linting issue? |
|
I'm running |
vijaysingh-axway
changed the title
|
@Brianggalvez Ideally it should work. I have fixed the listing issue. |
hansemannn
reviewed
Feb 9, 2019
| - name: dampingRatio | ||
| summary: Damping ratio of spring. Use a value between 0 and 1. For a smoother deceleration use values closer to 1. | ||
| type: Number, | ||
| platforms: [iphone, ipad] | ||
|
|
ssjsamir
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
FR Passed: Able to see the ampingRatio and springVelocity being applied to an animation. Tested with the test case mentioned in the description
Test Environment
iPhone 6 Sim (12.1)
APPC CLI: 7.0.10-14
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
|
It looks like "springVelocity" is really a scale factor, correct? Would If this is true, then perhaps the property should be renamed to "springScale". I'm asking from a portability standpoint. I'll see about writing this feature up for Android and Windows once we've settled on the design. |
|
Hi Joshua, just prepared a little example on what springVelocity does. It's the view initial velocity so as high it is more bouncing the view does at the end. For Android you can find this useful: https://proandroiddev.com/spring-animation-in-android-de3d4197879b
|
|
|
@vijaysingh-axway , I am not able to merge because it is asking for unit test. Can you please do the appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-18421
added dampingRatio and springVelocity to allow iOS spring animations
example :