New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TIMOB-26695): only use debug logs in core-sdk development #10572
Conversation
Tests:
|
+1 for the general idea of this. All the module loading debug is sometimes really cluttering the logs and hides the output that i'm actually interested in. However, this would remove this debugging info completely for end users, right? It might be nice to still display this info just for the case that a file wasn't found. So a user knows where we looked for his required file and can check what's wrong with his |
I agree, but even for that case, a reference to the Node.js algorithm could be posted. Since the lookup is incremental, we would need to store the lookup until a successful or failed lookup and discard it if not necessary. I'd really align to Node.js here and as it seems, they only show a trace of the require statement itself. |
We do report when a file is not found, but yeah we don't report the full listing of files we try. The output here is incidental - it's not really intended to be exposed and with my new fixes for require the listing of files/directories we try to load won't be displayed anyways. This only spits out when we try to load an encrypted asset. So, long story short: I think this should get merged in for 8.0.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is fine to me. Most of the original problem is actually solved by PR #10640 but this is debug level output that we shouldn't really be spitting out typically.
Mental note to self: needs to be cherry-picked to |
Can this be merged in master? We'd love to use this in our app. |
FR Passed. The debug logs related to Node.js paths are not shown in the console. |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26695
Note: This does not require unit- or ui-tests, since it is an internal change only and is only applied to the
Debug
version of the target.