Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): include shutdownUi() in TitaniumKit #10582

Closed
wants to merge 3 commits into from

Conversation

garymathews
Copy link
Contributor

  • Since TitaniumKit is precompiled, build time flags should be specified in the headers instead.
TEST CASE
const win = Ti.UI.createWindow();
win.addEventListener('click', () => {
    Ti.App._restart();
});
win.open()

JIRA Ticket

@garymathews garymathews added this to the 8.0.0 milestone Jan 8, 2019
@build build requested a review from a team January 8, 2019 19:38
@build
Copy link
Contributor

build commented Jan 8, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 2983 tests are passing.

Generated by 🚫 dangerJS against 17e48b2

@keerthi1032
Copy link
Contributor

FR passed. No Crash occurs. Waiting for CR to merge

Operating System
Name = Mac OS X
Version = 10.13.6
Memory = 17179869184
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local sdk 8.1.0.v20190108111453
device =iPhone 6s iOS 12,

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garymathews Will removing the wrapping of method from DEBUG macro not affect anything else? cc @janvennemann
There is one more issue TIMOB-26694 which is happening due to this flag here

@vijaysingh-axway
Copy link
Contributor

@garymathews I have fix this issue as part of TIMOB-26694 using a communication in framework via TiSharedConfig. Please review PR-10593

@sgtcoolguy
Copy link
Contributor

closed in favor of #10593

@sgtcoolguy sgtcoolguy closed this Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants