Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): amend Titanium ListView widget lookup #10586

Merged
merged 6 commits into from Jan 9, 2019
Merged

fix(android)(8_0_X): amend Titanium ListView widget lookup #10586

merged 6 commits into from Jan 9, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.0 milestone Jan 8, 2019
@lokeshchdhry
Copy link
Contributor

@garymathews , There are some issues with npm install while building. Can you please take a look.

@build
Copy link
Contributor

build commented Jan 9, 2019 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 2976 tests are passing.

Generated by 🚫 dangerJS against 020a518

@lokeshchdhry
Copy link
Contributor

FR Passed.

No TypeError: creationFunction is not a function is seen.

Studio Ver: 5.1.2.201812191831
SDK Ver: 8.0.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.9
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.4
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Pixel (Android 9)

@sgtcoolguy sgtcoolguy merged commit d53c188 into tidev:8_0_X Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @lokeshchdhry @build @sgtcoolguy