Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): amend hasActivityTransitions() for transitions #10589

Merged
merged 7 commits into from Apr 3, 2019
Merged

fix(android)(8_0_X): amend hasActivityTransitions() for transitions #10589

merged 7 commits into from Apr 3, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.0 milestone Jan 8, 2019
@build build requested a review from a team January 9, 2019 00:42
@build
Copy link
Contributor

build commented Jan 9, 2019 •
edited

Warnings
⚠️

🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

Generated by 🚫 dangerJS against 86c4cc6

@garymathews garymathews modified the milestones: 8.0.0, 8.0.1 Jan 14, 2019
jquick-axway
jquick-axway approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

Transitions works as expected when sharedElement has not been specified.

FYI : Transitions are not supported on Android 4.1

Studio Ver: 5.1.2.201903111843
SDK Ver: 8.0.1 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.10
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.9
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Pixel (Android 9)

@sgtcoolguy sgtcoolguy merged commit 6fe04f8 into tidev:8_0_X Apr 3, 2019
sgtcoolguy added a commit that referenced this pull request Apr 5, 2019
@sgtcoolguy
Revert "fix(android): amend hasActivityTransitions() for transitions (#…
d1f8404 
…10589)"

This reverts commit 6fe04f8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @lokeshchdhry @jquick-axway @sgtcoolguy @ssjsamir