Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios) : Debug macros behaviour in framework implemented using shared configuration (8_0_X) #10594

Merged
merged 1 commit into from Jan 9, 2019
Merged

fix(ios) : Debug macros behaviour in framework implemented using shared configuration (8_0_X) #10594

merged 1 commit into from Jan 9, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.0.0 milestone Jan 9, 2019
@build build requested a review from a team January 9, 2019 14:17
@build
Copy link
Contributor

build commented Jan 9, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 2 tests have failed There are 2 tests failing and 449 skipped out of 2983 total tests.

Tests:

Classname Name Time Error
android.Titanium.UI.TabbedBar Labels update 2.791 tabbedBar.labels.get is not a function
ios.Titanium.UI.TabbedBar Labels update 0.007 tabbedBar.labels.get is not a function. (In 'tabbedBar.labels.get(1)', 'tabbedBar.labels.get' is undefined)

Generated by 🚫 dangerJS against ae362b2

@longton95 longton95 self-requested a review January 9, 2019 14:52
longton95
longton95 approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed

Verified using the test cases in the ticket and in TIMOB-26119, errors and warnings are now shown in the log

ENV

iPhone 7 (12.0)
iOS Simulator (12.1)
Appc NPM: 4.2.13
Appc CLI: 7.0.9
Ti CLI: 5.1.1
Node: 8.12.0
NPM: 6.4.1

Awaiting CR for merge

janvennemann
janvennemann approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janvennemann janvennemann changed the title fix(ios) : Debug macros behaviour in framework implemented using shared configuration fix(ios) : Debug macros behaviour in framework implemented using shared configuration (8_0_X) Jan 9, 2019
@sgtcoolguy sgtcoolguy merged commit c67d680 into tidev:8_0_X Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@longton95 longton95 longton95 approved these changes

Assignees
No one assigned
Labels
bug no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @janvennemann @longton95 @sgtcoolguy