Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): validate read and write stream methods #10635

Merged
merged 3 commits into from Jan 22, 2019
Merged

fix(android): validate read and write stream methods #10635

merged 3 commits into from Jan 22, 2019

Conversation

garymathews
Copy link
Contributor

  • Validate stream sockets before attempting to read or write

JIRA Ticket

@garymathews garymathews added this to the 8.1.0 milestone Jan 18, 2019
@build build requested a review from a team January 18, 2019 19:55
@build
Copy link
Contributor

build commented Jan 18, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 2986 tests are passing.

Generated by 🚫 dangerJS against ae9372b

@garymathews garymathews mentioned this pull request Jan 18, 2019
Merged
@keerthi1032
Copy link
Contributor

keerthi1032 commented Jan 22, 2019 •
edited

FR passed. no warning on live view. Waiting for CR to merge
Name = Mac OS X
Version = 10.13.6
Memory = 17179869184
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Sdk =Local sdk
Device. =Samsung s5 android6
Emulator =Pixel 3xl android 9

@keerthi1032 keerthi1032 merged commit 0bdc07b into tidev:master Jan 22, 2019
@keerthi1032
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @keerthi1032 @lokeshchdhry