New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): TabbedBar crash caused by setting properties before window opened #10646
Conversation
…s" and "index" properties before parent window opened - Added additional property valdation and warning log messages.
|
android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUITabbedBar.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
Just one typo in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed: Changing TabbedBar properties "labels" and "index" before opening window no longer causes and application crash. Tested following the steps mentioned in the description above.
Test Environment
Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
@jquick-axway @ypbnv This does not work correctly and even causes a UI glitch now. See the ticket for details. |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-26758
Summary:
TabbedBar
parent window has been opened.TiUITabbedBar.java
file.Test:
[One | Two | Three]
, whereOne
is selected.[Red | Green | Blue]
, whereGreen
is selected.[Alpha | Beta | Charlie]
, whereCharlie
is selected.