New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): auto-select cert and/or profile for ios if only one valid entry #10649
Conversation
This should be cherry-picked to 8_0_X for an eventual 8.0.1 release (once 8.0.0 GA is out). |
|
@@ -1136,6 +1137,7 @@ iOSBuilder.prototype.configOptionPPuuid = function configOptionPPuuid(order) { | |||
relistOnError: true, | |||
complete: true, | |||
suggest: false, | |||
autoSelectOne: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this flag already implemented or where will this be handled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a feature of the fields
library Chris Barber wrote that we use to do all the prompting for config values: https://github.com/cb1kenobi/fields#fieldsselectopts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, autoSelectOne
has been a property for "select" fields for years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sweet, thanks for the clarification!
FR Passed. |
@sgtcoolguy Need to cherry-pick to 8_0_X? The ticket is marked with fix version 8.0.1 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26767
Description:
This is a simple usability enhancement that irked me when testing on my own personal device. I have only one valid non-expired cert and one wildcard profile. Yet I got prompted to select them every time I built to device for iOS. If there's only one possible value for those config options, have it get auto-selected rather than stop and prompt the user to select the only option.