Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): auto-select cert and/or profile for ios if only one valid entry #10649

Merged
merged 2 commits into from Mar 26, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Jan 25, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-26767

Description:
This is a simple usability enhancement that irked me when testing on my own personal device. I have only one valid non-expired cert and one wildcard profile. Yet I got prompted to select them every time I built to device for iOS. If there's only one possible value for those config options, have it get auto-selected rather than stop and prompt the user to select the only option.

@sgtcoolguy
Copy link
Contributor Author

This should be cherry-picked to 8_0_X for an eventual 8.0.1 release (once 8.0.0 GA is out).

@build build added this to the 8.1.0 milestone Jan 25, 2019
@build
Copy link
Contributor

build commented Jan 25, 2019

Warnings
⚠️

iphone/cli/commands/_build.js#L6412 - iphone/cli/commands/_build.js line 6412 – 'out' is defined but never used. (no-unused-vars)

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3633 tests are passing.

Generated by 🚫 dangerJS against f2a3f6d

@@ -1136,6 +1137,7 @@ iOSBuilder.prototype.configOptionPPuuid = function configOptionPPuuid(order) {
relistOnError: true,
complete: true,
suggest: false,
autoSelectOne: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this flag already implemented or where will this be handled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feature of the fields library Chris Barber wrote that we use to do all the prompting for config values: https://github.com/cb1kenobi/fields#fieldsselectopts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, autoSelectOne has been a property for "select" fields for years.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sweet, thanks for the clarification!

@ssekhri
Copy link

ssekhri commented Mar 26, 2019

FR Passed.
When building a project via cli and there is only a single appropriate certificate it gets auto-selected and not prompted for. Similarly the profile gets auto-selected if there is only a single profile for the selected certificate and app-id.
If there is more than one certificate or more than one profile for the selected certificate and app-id, the user is prompted to select the cert and/or profile.
Env:
Mac OS 10.14.3
Ti SDK: 8.1.0.v20190125091143
Appc CLI: 7.0.10
Node: 8.12.0
JDK: 9.0.4
XCode: 10.1

@ssekhri
Copy link

ssekhri commented Mar 26, 2019

@sgtcoolguy Need to cherry-pick to 8_0_X? The ticket is marked with fix version 8.0.1

@ssekhri ssekhri merged commit 329e868 into tidev:master Mar 26, 2019
@sgtcoolguy sgtcoolguy deleted the assume-only-cert branch March 27, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants