Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): Fixed bug where app launches without animation when launched with data intent #10651

Merged
merged 3 commits into from Mar 22, 2019
Merged

fix(android)(8_0_X): Fixed bug where app launches without animation when launched with data intent #10651

merged 3 commits into from Mar 22, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.0.1 milestone Jan 26, 2019
@build build requested a review from a team January 26, 2019 00:37
@build
Copy link
Contributor

build commented Jan 26, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3016 tests are passing.

Generated by 🚫 dangerJS against 6b616d1

garymathews
garymathews approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@ssekhri
Copy link

ssekhri commented Mar 20, 2019

FR Passed. The app launches with a fade-in animation when launched based on a data intent.
There was a flicker issue observed which is not easily noticeable and is intermittent and only on few devices.
Test Env:
Mac OS 10.14.3
Ti SDK: 8.0.0.v20190125161347
Appc CLI: 7.0.10
Node: 8.12.0
JDK: 9.0.4
Studio: 5.1.2.201903111843
Android Device: Pixel(v9.0), Pixel XL(v9.0), Galaxy S5(6.0), Nexus6 Emulator(v6.0)

@ssekhri ssekhri merged commit e8ab746 into tidev:8_0_X Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jquick-axway @build @ssekhri @garymathews