Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): expand SearchView by default #10656

Merged
merged 5 commits into from Mar 15, 2019

Conversation

garymathews
Copy link
Contributor

  • Expand Ti.UI.Android.SearchView by default
TEST CASE
const win = Ti.UI.createWindow({ backgroundColor: 'gray' });
const search = Ti.UI.Android.createSearchView();
const table = Titanium.UI.createTableView({
    data: [
        Ti.UI.createTableViewRow({ title:'Apple' }),
        Ti.UI.createTableViewRow({ title:'Banana' }),
        Ti.UI.createTableViewRow({ title:'Orange' }),
        Ti.UI.createTableViewRow({ title:'Raspberry' })
    ],
    search: search,
    searchAsChild: true
});

win.add(table);
win.open();

JIRA Ticket

@build
Copy link
Contributor

build commented Jan 30, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3611 tests are passing.

Generated by 🚫 dangerJS against 72212e5

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@garymathews garymathews modified the milestones: 8.0.0, 8.1.0 Feb 27, 2019
@ssjsamir ssjsamir self-requested a review March 15, 2019 12:50
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Pressing the SearchView bar now gains focus and ability to search.

Test Environment

Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit b72ff08 into tidev:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants