Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_0_X): Ti.App wrongly fires pause/resume events when opening/closing child windows #10658

Merged
merged 5 commits into from Mar 25, 2019

Conversation

jquick-axway
Copy link
Contributor

…ume events when opening/closing child windows

- Updated Ti.App docs to indicate Android supported these events since 7.5.0
@build
Copy link
Contributor

build commented Jan 30, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 4 tests have failed There are 4 tests failing and 450 skipped out of 3017 total tests.

Tests:

Classname Name Time Error
android.emulator.os #freemem() returns a positive Number 0.002 expected 0 to be above 0
android.emulator.Titanium.Android activity callbacks 20.862 timeout of 5000ms exceeded
android.emulator.Titanium.UI.Layout layoutWithSIZE_and_fixed 9.888 timeout of 5000ms exceeded
android.emulator.Titanium.UI.Layout undefinedRight 18.888 timeout of 5000ms exceeded

Generated by 🚫 dangerJS against b245166

jquick-axway and others added 3 commits March 15, 2019 16:53
- Changed "TiApplicationLifecycle" class' static variables to instance member variables. They don't need to be static.
@ssekhri
Copy link

ssekhri commented Mar 20, 2019

FR Passed.
The 'resumed' event is fired on app launch, and 'resume', 'resumed' events are fired on app foreground. They do not get fired when a window is opened.
The 'pause' and 'paused' events are fired on app background only. They do not get fired on window close.
Test Env:
Mac OS 10.14.3
Ti SDK: 8.0.0.v20190315171321
Appc CLI: 7.0.10
Node: 8.12.0
JDK: 9.0.4
Studio: 5.1.2.201903111843
Android Device: Pixel(v9.0), Nexus6 Emulator(v6.0)

@sgtcoolguy sgtcoolguy merged commit bf6530e into tidev:8_0_X Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants