fix(android): don't copy Ti.Buffer properties not set during #clone() #10670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26789
Optional Description:
Exposed by a stricter equality check in a newer
should.js
- when cloning a Ti.Buffer, the clone would getnull
values fortype
andvalue
if the original had no values for those properties so the equality check would fail (null !== undefined
, whereas beforenull == undefined
)Note that this fix is already merged to
master