Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): rememberProxy call on overlay proxy for main thread #10685

Merged
merged 4 commits into from Feb 12, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway added this to the 8.1.0 milestone Feb 7, 2019
@build build requested a review from a team February 7, 2019 18:20
@build
Copy link
Contributor

build commented Feb 7, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 2990 tests are passing.

Generated by 🚫 dangerJS against ca09897

@ssjsamir ssjsamir self-requested a review February 12, 2019 15:50
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Event listener on the overlay is now working for the camera when camera is kept idle for a few minutes.
Test Case:

var win = Ti.UI.createWindow({

backgroundColor: '#fff'
});
 
win.addEventListener('click', function(){
onGalleryOverlay();
});
 
function onGalleryOverlay() {
var overlay = Ti.UI.createView({
height: Ti.UI.FILL,
width: Ti.UI.FILL
});
var closeBtn = Ti.UI.createButton({
width: "80dp",
height: "80dp",
backgroundColor: "yellow",
top: "20dp",
right: "20dp"
});
closeBtn.addEventListener("click", function() {
Ti.Media.hideCamera();
});
 
overlay.addEventListener("click", function() {
Ti.API.info('ovelay clicked');
Ti.Media.hideCamera();
});
 
overlay.add(closeBtn);
Ti.Media.showCamera({
mediaTypes: [Ti.Media.MEDIA_TYPE_VIDEO],
showControls: false,
overlay: overlay,
saveToPhotoGallery : true,
autohide : false,
 
success:function(e) {
console.log("\n success");
},
cancel: function() {
console.log("cancel");
},
error:function(error) {
console.log("error");
}
});
}
win.open();

Test Environment

iPhone 6s plus (12.1)
APPC CLI: 7.0.10-14
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@ssjsamir ssjsamir merged commit 10d0813 into tidev:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants