New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): update aps libraries to fix memory leak (8_0_X) #10705
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
@janvennemann I tried the sample app as mentioned in corresponding jira and ran it with the SDK 8.0.0.v20190215120515 available from jenkins build for this PR. I still see leaks from the app when i run it on simulator or device. |
@janvennemann I tried the latest commit on few devices and simulator. Still see some related leaks though the latest commit is much better than the last one. |
Just confirming, this isn't in the 8_0_X nightly builds yet (or any other build for that matter)? |
FR Passed. No more memory leaks seen related to APSHTTP library. |
@tristankenney This just passed QE testing and is available in the 8_0_X nightly builds after this PR has been merged (once the CI build status check passed). |
@janvennemann, the master branch merged successfully. However the Jenkins build is failing for 8_0_X. Can you kindly check. |
Can someone confirm for me that these changes have made their way into the the built 8.0.1.v20190326110553 and later? I've been testing against this build and have not seen a significant reduction in the memory leak. |
@janvennemann Here is a ref to a new ticket that documents our findings |
Basically the issue that i see is that memory is consumed by the request and 5, 10 minutes later it still not been freed. In contract the 6.30.0.GA frees the memory up after a minute or 2 |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26811
8_0_X backport of #10704