Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): update aps libraries to fix memory leak (8_0_X) #10705

Merged
merged 4 commits into from Mar 25, 2019

Conversation

janvennemann
Copy link
Contributor

@build
Copy link
Contributor

build commented Feb 15, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3019 tests are passing.

Generated by 🚫 dangerJS against ea74de9

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssekhri
Copy link

ssekhri commented Mar 6, 2019

@janvennemann I tried the sample app as mentioned in corresponding jira and ran it with the SDK 8.0.0.v20190215120515 available from jenkins build for this PR. I still see leaks from the app when i run it on simulator or device.
Just one device iPhone XS (iOS version 12.1.3) i do not see any leaks. That device didnt show me any leaks on 7.5.0.GA as well.
For other devices I still see leaks though they seemed less than 7.5.0.GA.
Check some of the saved instrument trace using the 8.0.0.v20190215120515 SDK. You can get them from https://axwaysoftware-my.sharepoint.com/personal/ssekhri_axway_com/Documents/Leaktest/LeakTestTrace.zip

@janvennemann janvennemann changed the title fix(ios): update APSHTTPClient to fix memory leak (8_0_X) fix(ios): update aps libraries to fix memory leak (8_0_X) Mar 11, 2019
@janvennemann
Copy link
Contributor Author

@ssekhri please give it another try with the latest build.

@ssekhri
Copy link

ssekhri commented Mar 18, 2019

@janvennemann I tried the latest commit on few devices and simulator. Still see some related leaks though the latest commit is much better than the last one.
You can find the latest leak trace from https://axwaysoftware-my.sharepoint.com/:u:/g/personal/ssekhri_axway_com/ESkrx8p-4INIt2L9wgQcXScBJF0_Hif8nAeOernICt6axQ?e=1UU1wF

@tristankenney
Copy link

tristankenney commented Mar 25, 2019

Just confirming, this isn't in the 8_0_X nightly builds yet (or any other build for that matter)?

@ssekhri
Copy link

ssekhri commented Mar 25, 2019

FR Passed. No more memory leaks seen related to APSHTTP library.
Env:
Mac OS 10.14.3
Ti SDK: 8.0.0.v20190325032239
Appc CLI: 7.0.10
Node: 8.12.0
JDK: 9.0.4
Studio: 5.1.2.201903111843
Xcode: 10.1
Devices: Sim iPhone8(v12.1). Sim iPhone6(v10.0), iPhoneXS(v12.1.3), iPhone7(12.1.1), iPadMini(v9.3.5)

@janvennemann
Copy link
Contributor Author

@tristankenney This just passed QE testing and is available in the 8_0_X nightly builds after this PR has been merged (once the CI build status check passed).

@ssekhri
Copy link

ssekhri commented Mar 25, 2019

@janvennemann, the master branch merged successfully. However the Jenkins build is failing for 8_0_X. Can you kindly check.

@ssekhri ssekhri merged commit 12af628 into tidev:8_0_X Mar 25, 2019
@nmuecke
Copy link

nmuecke commented Mar 28, 2019

Can someone confirm for me that these changes have made their way into the the built 8.0.1.v20190326110553 and later? I've been testing against this build and have not seen a significant reduction in the memory leak.
Will aim to update https://jira.appcelerator.org/browse/TIMOB-26811 with additional details tomorrow

@nmuecke
Copy link

nmuecke commented Apr 3, 2019

@janvennemann Here is a ref to a new ticket that documents our findings
https://jira.appcelerator.org/browse/AC-6190

@nmuecke
Copy link

nmuecke commented Apr 3, 2019

Basically the issue that i see is that memory is consumed by the request and 5, 10 minutes later it still not been freed. In contract the 6.30.0.GA frees the memory up after a minute or 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants