Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove startup log from titaniumkit #10708

Merged
merged 2 commits into from Mar 28, 2019

Conversation

ewanharris
Copy link
Collaborator

This is now done via the ti.main script. Closes TIMOB-26833

JIRA: https://jira.appcelerator.org/browse/TIMOB-26833

⚠️ Note: the log that was being output had the SDK down as (0.0.0.(null)), and TITANIUM_VERSION is being set to 0.0.0 I can't find anywhere where we're referencing that? But if we are, whatever uses it is using invalid information?

Test steps

  • Build an app to iOS device/sim, on startup only one log like plainalloy 1.0 (Powered by Titanium 8.1.0.849c15e098) should be output.

@ewanharris ewanharris added the bug label Feb 18, 2019
@ewanharris
Copy link
Collaborator Author

Added a (naive) check to add a warning if the TopTiModule.m changes during scons build are committed.

@build build added this to the 8.1.0 milestone Feb 18, 2019
@build build requested a review from a team February 18, 2019 12:09
@build
Copy link
Contributor

build commented Feb 18, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 1 tests have failed There are 1 tests failing and 462 skipped out of 3633 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.UI.TableView SearchView persistence 2.36 timeout of 2000ms exceeded

Generated by 🚫 dangerJS against 9141552

@jquick-axway
Copy link
Contributor

Nice find. I did remove that log message in my PR below, but it looks like it was copied into TitaniumKit later.
https://github.com/appcelerator/titanium_mobile/pull/10112/files#diff-4c87204e7b1bd7f7c84399ab50226410

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy
Copy link
Contributor

@ewanharris Note that I also (secretly) added a git hook commit check that enforces no one checked in static values in the TopTiModule.m file. Obviously the hook can be bypassed, but I wanted to try and avoid this situation too.

@sgtcoolguy sgtcoolguy merged commit 34941cd into tidev:master Mar 28, 2019
@ewanharris ewanharris deleted the TIMOB-26833 branch March 28, 2019 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants