New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): remove startup log from titaniumkit #10708
Conversation
Added a (naive) check to add a warning if the TopTiModule.m changes during scons build are committed. |
Tests:
|
Nice find. I did remove that log message in my PR below, but it looks like it was copied into TitaniumKit later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
@ewanharris Note that I also (secretly) added a git hook commit check that enforces no one checked in static values in the TopTiModule.m file. Obviously the hook can be bypassed, but I wanted to try and avoid this situation too. |
This is now done via the ti.main script. Closes TIMOB-26833
This is now done via the ti.main script. Closes TIMOB-26833
JIRA: https://jira.appcelerator.org/browse/TIMOB-26833
TITANIUM_VERSION
is being set to0.0.0
I can't find anywhere where we're referencing that? But if we are, whatever uses it is using invalid information?Test steps
plainalloy 1.0 (Powered by Titanium 8.1.0.849c15e098)
should be output.