New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android)(8_0_X): resolve template compatibility with Java 9+ #10712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see comments/review on #10706 |
garymathews
force-pushed
the
TIMOB-26826_80X
branch
from
February 26, 2019 19:08
a0b19ff
to
15c0652
Compare
sgtcoolguy
approved these changes
Mar 18, 2019
ssjsamir
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed Able to build Ti.playservices and then include it in titanium application
Test Steps
- Downloaded ti.playservices
- cd in to ti.playservices
- cd into Android folder
- Created lib folder
- cd in to ti.playservices root
- cd into the updater folder
- did npm install node .
- did npm install && node .
- cd in to ti.playservices root
- cd into Android folder
- run appc run -p android --build-only
- added the module to a titanium application
- added the code in to the {{app.js}}
const PlayServices = require('ti.playservices');
const win = Ti.UI.createWindow({ backgroundColor: 'gray' });
const btn = Ti.UI.createButton({ title: 'CHECK PLAY SERVICES' });
btn.addEventListener('click', () => {
PlayServices.makeGooglePlayServicesAvailable((e) => {
if (e.success) {
alert(`Play Services: ${PlayServices.GOOGLE_PLAY_SERVICES_VERSION_CODE}`);
// Use Play Services
} else {
alert(`Play Services is not available.`);
}
});
});
win.add(btn);
win.open();
- ran the program
- pressed check play services
- version number was returned
Test Environment
Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket