Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_0_X): resolve template compatibility with Java 9+ #10712

Merged
merged 13 commits into from Mar 25, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.1 milestone Feb 19, 2019
@build build requested a review from a team February 19, 2019 23:09
@build
Copy link
Contributor

build commented Feb 19, 2019

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3016 tests are passing.

Generated by 🚫 dangerJS against e086e09

@sgtcoolguy
Copy link
Contributor

see comments/review on #10706

@ssjsamir ssjsamir self-requested a review March 20, 2019 17:33
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Able to build Ti.playservices and then include it in titanium application

Test Steps

  1. Downloaded ti.playservices
  2. cd in to ti.playservices
  3. cd into Android folder
  4. Created lib folder
  5. cd in to ti.playservices root
  6. cd into the updater folder
  7. did npm install node .
  8. did npm install && node .
  9. cd in to ti.playservices root
  10. cd into Android folder
  11. run appc run -p android --build-only
  12. added the module to a titanium application
  13. added the code in to the {{app.js}}
const PlayServices = require('ti.playservices');

const win = Ti.UI.createWindow({ backgroundColor: 'gray' });
const btn = Ti.UI.createButton({ title: 'CHECK PLAY SERVICES' });

btn.addEventListener('click', () => {
    PlayServices.makeGooglePlayServicesAvailable((e) => {
        if (e.success) {
            alert(`Play Services: ${PlayServices.GOOGLE_PLAY_SERVICES_VERSION_CODE}`);
            // Use Play Services
        } else {
            alert(`Play Services is not available.`);
        }
    });
});

win.add(btn);
win.open();
  1. ran the program
  2. pressed check play services
  3. version number was returned

Test Environment

Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 66f4755 into tidev:8_0_X Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants