TiAPI: Create Node-compatible util module API #10718
Conversation
|
| + ' [prototype]: func { [constructor]: [Circular] } } }'); | ||
| }); | ||
|
|
||
| it.skip('with nested object', () => { |
There was a problem hiding this comment.
⚠️ tests/Resources/util.addontest.js line 385 – Unexpected skipped mocha test. (mocha/no-skipped-tests)
| + ' [length]: 1 ] }'); | ||
| }); | ||
|
|
||
| it.skip('with same object twice', () => { |
There was a problem hiding this comment.
⚠️ tests/Resources/util.addontest.js line 403 – Unexpected skipped mocha test. (mocha/no-skipped-tests)
| debug: string => console.error(`DEBUG: ${string}`) | ||
| }; | ||
|
|
||
| util.isBuffer = () => false; // FIXME: Check for Ti.Buffer? for node/browserify buffer? |
There was a problem hiding this comment.
Maybe a Buffer interface around our Ti.Buffer?
| util.isRegexp = value => util.types.isRegexp(value); | ||
|
|
||
| // FIXME: Our String.format is not very forgiving. It sort-of is supposed to do the same thing, but blows up easily | ||
| // util.format = String.format; |
There was a problem hiding this comment.
Can this be removed? since you wrote your own format function further down?
There was a problem hiding this comment.
yeah, it was a reminder as I tried to use our String.format as a placeholder and it broke right away.
| return eventListeners.length !== 0; | ||
| }, | ||
| eventNames: () => Object.getOwnPropertyNames(listeners), | ||
| emitWarning: function (warning, options, code, ctor) { |
There was a problem hiding this comment.
⚠️ common/Resources/ti.internal/extensions/process.js line 77 – 'ctor' is defined but never used. (no-unused-vars)
| }); | ||
| // TODO: don't do deeper objects like this until we support the breakLength crap? | ||
|
|
||
| it.skip('with object', () => { |
There was a problem hiding this comment.
⚠️ tests/Resources/util.addontest.js line 369 – Unexpected skipped mocha test. (mocha/no-skipped-tests)
…ctures that throw Error
…merable properties of objects
…roperties are removed
…, traceDeprecation, emit/on/emitWarning
…ct() output not labeled Circular
| return Promise.reject(null); | ||
| } | ||
| const callbackified = util.callbackify(original); | ||
| callbackified((err, result) => { |
There was a problem hiding this comment.
⚠️ tests/Resources/util.addontest.js line 881 – 'result' is defined but never used. (no-unused-vars)
| expected); | ||
| }); | ||
|
|
||
| it.skip('with nested object and default depth', () => { |
There was a problem hiding this comment.
⚠️ tests/Resources/util.addontest.js line 636 – Unexpected skipped mocha test. (mocha/no-skipped-tests)
JIRA: https://jira.appcelerator.org/browse/TIMOB-26670
Description:
util._extends()util.isDeepStrictEqual(), which would be done after TiAPI: Create Node-compatible assert module API #10661 was also merged.util.inspectoptions too far. We supportdepthandshowHidden, and to some degreebreakLength; I didn't handleshowProxy,compact,maxArrayLength,colors,customInspect,sortedcustom functions (just Boolean). I also assume there's lots of edge cases like WeakMaps, WeakSets, Map/Set iterators, etc that we don't properly support yet.Note that due to the way iOS proxies are set up, I can't verify the format of util.log/error/debug/puts/print messages because we cannot override
console.logorconsole.error.#10069 would fix that issue.