feat(android): Adds extended support for color customization of Ti.UI.Android.SearchView

[ypbnv]

JIRA: https://jira.appcelerator.org/browse/TIMOB-26822

Description:
Adds a few new properties for color customization of Ti.UI.Android.SearchView.

Test case:
app.js

var window = Ti.UI.createWindow({
		title: 'Search Test',
		layout: 'vertical'
	}),
	searchViewActionBar = Ti.UI.Android.createSearchView({
		hintText: 'Action Bar Search',
		hintTextColor: 'cyan',
		iconSearchColor: 'magenta',
		iconSearchHintColor: 'yellow'
	}),
	searchViewIconified = Ti.UI.Android.createSearchView({
		hintText: 'Action Bar Default',
		hintTextColor: 'blue',
		iconSearchColor: 'green',
		iconSearchHintColor: 'red',
		iconSearchCloseColor: 'orange'
	}),
	searchViewNonIconified = Ti.UI.Android.createSearchView({
		hintText: 'Action Bar Non Iconified',
		iconifiedByDefault: false,
		hintTextColor: 'red',
		iconSearchColor: 'green',
		iconSearchHintColor: 'blue',
		iconSearchCloseColor: 'purple'
	});

window.activity.onCreateOptionsMenu = function(e) {
	e.menu.add({
		title: 'Search',
		actionView: searchViewActionBar,
		icon: Ti.Android.R.drawable.ic_menu_search,
		showAsAction: Ti.Android.SHOW_AS_ACTION_IF_ROOM | Ti.Android.SHOW_AS_ACTION_COLLAPSE_ACTION_VIEW,
	});
};
window.add([searchViewIconified, searchViewNonIconified]);
window.open();

[jquick-axway]

Regarding the property names, perhaps we should rename them:

• "iconSearchColor" -> "iconSearchTintColor"
• "iconSearchCloseColor" -> "iconSearchCloseTintColor"
• "iconSearchHintColor" -> "iconSearchHintTintColor"

Notice that I added the word "Tint" to the above properties.
This is for consistency with our other tint color properties such as:

• ProgressBar.trackTintColor
• Window.navTintColor
• TabGroup.unselectedItemTintColor
• TabGroup.activeTabIconTint(This one is missing the word "Color".)

I'm also contemplating if the word "Search" is necessary in the property names since all properties belonging to SearchView is search related. For example, a property named closeIconTintColor may be good enough.

@garymathews, do you have an opinion on the property names?

[ypbnv]

I agree with the proposed name changes and I will update them.

[jquick-axway]

Member variable searchView can be null when this object's release() method gets called. So, we need to do a null check in all update methods.

Also, I'm not sure how I feel about blindly casting the reference returned by findViewById() to EditText. We could run into a class cast exception if the support library changes the implementation in the future. I'm thinking that this is likely to happen once we add gradle support and devs can have better control of the support library version they're using. Perhaps changing the catch() block below to catch Exception instead of ResourceNotFoundException would be better.

[jquick-axway]

I think you need to call searchIconDrawable.mutate() since you're receiving a global reference to the drawable here.

[jquick-axway]

^ The above makes me nervous. It makes assumptions about the internal implementation details on Google's end, which could change in the future. Is there really no other nice way to do this? I was able to replace this icon via a theme/style, except when the SearchView was embedded within the ActionBar.

[jquick-axway]

I mean, you might be right. There might be no other way to do this without hacks... but we then have to be concerned about potential breakage/issues in the future.

[ypbnv]

From what I tested providing a custom theme with overridden properties for close, hintIcon and searchIcon worked just fine. The case where I embedded the SearchView as a Menu item in the ActionBar required to separately pass the drawable I used for <item name="searchIcon">@drawable/pictureduo</item> because it is different from the already embedded resources which are referenced by ID (like the sample icon: Ti.Android.R.drawable.ic_menu_search,)
Possibly the biggest benefit would be that we can have partial parity with the properties of Ti.UI.SearchBar, but that leaves us at "Is it worth it to have that at the price of blindly assuming what is happening under the AppCompat library?" Maybe we can discuss this in details offline ?

[build]

	Warnings
⚠️	Commit 895e42752bf9ca9a27b0cef7ac408dd3acc03edd has a message "feat(android): Adds extended support for color customization of Ti.UI.Android.SearchView" giving 2 errors: header must not be longer than 72 characters, current length is 88 subject must not be sentence-case, start-case, pascal-case, upper-case

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 3701 tests are passing. (There are 470 tests skipped)
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

Generated by 🚫 dangerJS against b170d17