fix(android): also use GPS for low accuracy

[garymathews]

• Also use GPS provider for low accuracy
• Remove more legacy code
• Fix STATE_DISABLED to output as an error
• Allow requestLocationPermissions to fall through when permissions are already granted

TEST CASE

const win = Ti.UI.createWindow({ backgroundColor: 'gray' });
const listView = Ti.UI.createListView();
let count = 1;

Ti.Geolocation.accuracy = Ti.Geolocation.ACCURACY_LOW;

function push (e) {
    let section = Ti.UI.createListSection({ headerTitle: '#' + count++ });
    if (e.success) {
        if (e.coords) {
            e = e.coords;
        }
        section.setItems([
            { properties: { title: 'LOCATION:\n' + e.latitude + ', ' + e.longitude, color: 'orange' } },
            { properties: { title: 'ALTITUDE:\n' + e.altitude, color: 'orange' } },
            { properties: { title: 'ACCURACY:\n' + e.accuracy, color: 'orange' } }
        ]);
    } else {
        section.setItems([
            { properties: { title: 'ERROR:\n' + e.error, color: 'red' } }
        ]);
    }
    listView.appendSection(section);
}

function getLocation () {
    Ti.Geolocation.addEventListener('location', push);
}

win.addEventListener('open', () => {
    Ti.Geolocation.requestLocationPermissions(Ti.Geolocation.AUTHORIZATION_ALWAYS, (e) => {
        if (e.success) {
            getLocation();
        } else {
            alert('could not obtain location permissions');
        }
    });
});

win.add(listView);
win.open();

JIRA Ticket

[build]

	Messages
📖	👍 Hey!, You deleted more code than you added. That's awesome!
📖	💾 Here's the generated SDK zipfile.
📖	✅ All tests are passing Nice one! All 2991 tests are passing.

Generated by 🚫 dangerJS against 1cf9cb1

[jquick-axway]

CR: Pass

[jquick-axway]

Excellent! Good find.

[ssjsamir]

FR Passed Able to get the Location, Altitude and Accuracy when using Ti.Geolocation.ACCURACY_LOW. Tested with the test case above.

Test Environment

Google pixel xl 7.1 Sim
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1