Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): expand SearchView by default #10732

Merged
merged 3 commits into from Mar 15, 2019
Merged

fix(android)(8_0_X): expand SearchView by default #10732

merged 3 commits into from Mar 15, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.1 milestone Feb 27, 2019
@build build requested a review from a team February 28, 2019 00:04
@build
Copy link
Contributor

build commented Feb 28, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3001 tests are passing.

Generated by 🚫 dangerJS against 7402d91

@ssjsamir ssjsamir self-requested a review March 15, 2019 12:53
ssjsamir
ssjsamir approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Pressing the SearchView bar now gains focus and ability to search.

Test Environment

Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 1ca8d03 into tidev:8_0_X Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @ssjsamir @sgtcoolguy