Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): fix stringify of View #10742

Merged
merged 3 commits into from Mar 25, 2019
Merged

fix(android): fix stringify of View #10742

merged 3 commits into from Mar 25, 2019

Conversation

garymathews
Copy link
Contributor

  • Missing null check can cause JSON.stringify() to fail

JIRA Ticket

@garymathews garymathews added this to the 8.1.0 milestone Mar 1, 2019
@garymathews garymathews mentioned this pull request Mar 1, 2019
Merged
@build build requested a review from a team March 1, 2019 19:12
@build
Copy link
Contributor

build commented Mar 1, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3631 tests are passing.

Generated by 🚫 dangerJS against c94eff2

jquick-axway
jquick-axway approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir self-requested a review March 25, 2019 12:17
ssjsamir
ssjsamir approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, JSON.stringify() no longer fails. tested using the following test cases (regression tests):

Test Environment

Google pixel xl 7.1.1 sim
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@ssjsamir ssjsamir merged commit 4becfe6 into tidev:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @ssjsamir @jquick-axway