Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove event listener handled properly for local webview #10747

Merged
merged 2 commits into from Mar 6, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.1.0 milestone Mar 4, 2019
@build build requested a review from a team March 4, 2019 10:04
@build
Copy link
Contributor

build commented Mar 4, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 2995 tests are passing.

Generated by 🚫 dangerJS against e9321c3

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Removing event listener for local web view is now handled properly. Tested with the instructions found in https://jira.appcelerator.org/browse/TIMOB-26866

Test Environment

iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@ssjsamir ssjsamir merged commit 45d776d into tidev:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants