Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26239] Android: remove Ti.UI.currentWindow #10749

Merged
merged 4 commits into from Apr 3, 2019

Conversation

drauggres
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-26239

Ti.UI.currentWindow was deprecated and removed from other platforms long time ago, but is still present on Android (and cause memory leaks).

@build build added this to the 8.1.0 milestone Mar 5, 2019
@build build requested a review from a team March 5, 2019 10:38
@build
Copy link
Contributor

build commented Mar 5, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍
📖 ❌ 1 tests have failed There are 1 tests failing and 462 skipped out of 3633 total tests.

Tests:

Classname Name Time Error
ios.Titanium.UI.NavigationWindow #popToRootWindow 10.002 timeout of 10000ms exceeded

Generated by 🚫 dangerJS against a13e6e6

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@keerthi1032
Copy link
Contributor

FR Passed. Excueted TIMOB-4946 acceptance test which uses Ti.UI. current window getting undefined as expected.
Test Environment:
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Cli =7.0.10
studio =5.1.2.201903111843
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local 8.0.1.v20190321142528 and local master sdk 8.1.0.v20190321142031
Device =samsung s5 android 6
Emulator = PIXEL android8, nexus android 5
Target Platform = android

@sgtcoolguy sgtcoolguy merged commit 1c73ead into tidev:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants