fix(ios): Supported WKURLSchemeHandler to load custom url scheme (8_0_X) #10750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
janvennemann
approved these changes
Mar 6, 2019
janvennemann
changed the title
ssjsamir
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
FR Passed. HTML assigned to WebView "html" property is now able to access app's local files.
Tested using the following test case:
var htmlText =
'<!DOCTYPE html>' +
'<html>' +
' <head>' +
' <meta name="viewport" content="width=device-width, initial-scale=1.0">' +
' </head>' +
' <body>' +
' <p>Local Image File</p>' +
// ' <img src="assets/images/tab1.png"/>' +
' <img src="app://Resources/assets/images/tab1.png"/>' +
' </body>' +
'</html>';
var window = Ti.UI.createWindow();
var webView = Ti.UI.createWebView({
html: htmlText,
});
window.add(webView);
window.open();
Test Environment
iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1
|
FR Passed: Able to use 'img src="assets/images/tab1.png"/' as well as img src="app://Resources/assets/images/tab1.png"/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26860