Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): require of hyperloop js files works again (8_0_X) #10753

Merged
merged 2 commits into from Mar 6, 2019
Merged

fix(ios): require of hyperloop js files works again (8_0_X) #10753

merged 2 commits into from Mar 6, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Mar 5, 2019 •
edited by janvennemann

@sgtcoolguy sgtcoolguy added this to the 8.0.0 milestone Mar 5, 2019
@sgtcoolguy sgtcoolguy mentioned this pull request Mar 5, 2019
Merged
@build
Copy link
Contributor

build commented Mar 5, 2019 •
edited

Warnings
⚠️

iphone/cli/commands/_build.js#L6406 - iphone/cli/commands/_build.js line 6406 – 'out' is defined but never used. (no-unused-vars)
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 2991 tests are passing.

Generated by 🚫 dangerJS against 138c827

janvennemann
janvennemann approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janvennemann janvennemann changed the title fix(ios): require of hyperloop js files works again fix(ios): require of hyperloop js files works again (8_0_X) Mar 6, 2019
@ssjsamir ssjsamir self-requested a review March 6, 2019 12:08
ssjsamir
ssjsamir approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed Able to use hyperloop again. Tested with the hyperloop-examples project.

Test Environment

iPhone 6S plus (12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@ssjsamir ssjsamir merged commit 4b8a7cd into tidev:8_0_X Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
bug cli 📟 in-qe-testing 🕵 ios
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgtcoolguy @build @janvennemann @ssjsamir