Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix leak in TiBlob imageAsCompressed method (8_0_X) #10755

Merged
merged 4 commits into from Mar 22, 2019
Merged

fix(ios): fix leak in TiBlob imageAsCompressed method (8_0_X) #10755

merged 4 commits into from Mar 22, 2019

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann added this to the 8.0.1 milestone Mar 6, 2019
@janvennemann janvennemann changed the title fix(ios): fix leak in TiBlob imageAsCompressed method fix(ios): fix leak in TiBlob imageAsCompressed method (8_0_X) Mar 6, 2019
@janvennemann janvennemann mentioned this pull request Mar 6, 2019
Merged
@build build requested a review from a team March 6, 2019 14:09
@build
Copy link
Contributor

build commented Mar 6, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3015 tests are passing.

Generated by 🚫 dangerJS against 97b30a9

@keerthi1032
Copy link
Contributor

FR passed. deallocating memory as expected.

Test Environment:
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Memory = 17179869184
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDk version =local 8.0 sdk 8.0.1.v20190318134648
Studio = 5.1.2.201903111843
Cli =7.0.10
Device =iPhone 6s iOS 12
Simulator = iPhone 6 plus iOS 11.4, iPhone 5s iOS 11

@keerthi1032
Copy link
Contributor

@janvennemann danger failed which preventing me to merge. can you please merge it.

@keerthi1032 keerthi1032 merged commit d5d4787 into tidev:8_0_X Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@janvennemann @build @keerthi1032 @sgtcoolguy @rlustemberg @vijaysingh-axway @lokeshchdhry