Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Fix setting an active tab for TabGroup before opening. (8_0_X) #10759

Merged
merged 5 commits into from Mar 8, 2019
Merged

fix(android): Fix setting an active tab for TabGroup before opening. (8_0_X) #10759

merged 5 commits into from Mar 8, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Mar 7, 2019

@ypbnv
fix(android): Fix setting an active tab for TabGroup before opening.
799ac81 
Fixes setting an active tab for TabGroup before it is opened. Fixes backwards compatiblity for
events. Removes unused code. Clean up imports. Adds new unit tests. Updates docs. Fixes TIMOB-26843
@ypbnv
refactor(android): Add some null check guards.
0891a64
@ypbnv
fix(android): Removing of a Tab's parent is now on proxy release inst…
23a07a8 
…ead of views release.
@ypbnv ypbnv added this to the 8.0.0 milestone Mar 7, 2019
@ypbnv ypbnv requested a review from jquick-axway March 7, 2019 15:41
@ypbnv ypbnv added the no tests label Mar 7, 2019
@build build requested review from a team March 7, 2019 16:06
@build build added the docs label Mar 7, 2019
@build
Copy link
Contributor

build commented Mar 7, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 1 tests have failed There are 1 tests failing and 234 skipped out of 1424 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.Android activity callbacks 5.383 timeout of 5000ms exceeded

Generated by 🚫 dangerJS against da6b01b

@keerthi1032
Copy link
Contributor

FR passed. Jenkins is failing. Waiting for Resolving jenkin test failure to merge.

@sgtcoolguy sgtcoolguy merged commit ec14396 into tidev:8_0_X Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway Awaiting requested review from jquick-axway

Assignees
No one assigned
Labels
android bug docs no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ypbnv @build @keerthi1032 @sgtcoolguy @ssjsamir