Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Fixes changing background colors for Tabs after they are drawn. (8_0_X) #10763

Merged
merged 4 commits into from Mar 11, 2019

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Mar 8, 2019

…e drawn.

Fixes changing TabGroup and Tab background colors for different states after the creation of the
components. Fixes TIMOB-26859.
@ypbnv ypbnv added this to the 8.0.0 milestone Mar 8, 2019
@ypbnv ypbnv requested a review from jquick-axway March 8, 2019 17:50
@ypbnv ypbnv changed the title Timob 26859 8 0 x fix(android): Fixes changing background colors for Tabs after they are drawn. (8_0_X) Mar 8, 2019
@build build requested a review from a team March 8, 2019 18:12
@build
Copy link
Contributor

build commented Mar 8, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 3001 tests are passing.

Generated by 🚫 dangerJS against 4887ff2

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir
Copy link
Contributor

@ypbnv Please could you take a look at the merge conflicts?

@ssjsamir ssjsamir self-requested a review March 11, 2019 14:34
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to change background colors for Tabs after they are drawn. Tested using the test cases mentioned in #10756

Test Environment

Pixel XL api 28 
iPhone 6(12.1 Sim)
APPC CLI: 7.0.10-17
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 4f85b94 into tidev:8_0_X Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants