Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): delay js object creation to prevent accidental GC (8_0_X) #10772

Merged
merged 14 commits into from May 10, 2019
Merged

fix(ios): delay js object creation to prevent accidental GC (8_0_X) #10772

merged 14 commits into from May 10, 2019

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann added this to the 8.0.1 milestone Mar 12, 2019
@janvennemann janvennemann changed the title fix(ios): invoke event callbacks handling synchronously fix(ios): invoke event callbacks handling synchronously (8_0_X) Mar 12, 2019
@build build requested a review from a team March 12, 2019 11:16
@build
Copy link
Contributor

build commented Mar 12, 2019 •
edited

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3025 tests are passing.

Generated by 🚫 dangerJS against 663f55b

@mukherjee2
Copy link
Contributor

@vijaysingh-axway based on the last comment in the JIRA ticket, should this be moved to "Reopen" in JIRA?

@vijaysingh-axway
Copy link
Contributor

vijaysingh-axway commented Mar 26, 2019 •
edited

@mukherjee2 This ticket is not closed yet. I have seen that @janvennemann has pushed few commits in #10771 (which might fix the issue) which need to be backported here. @janvennemann Can we mark ticket 'In Progress' as you are still working on this or it is done?

@janvennemann janvennemann changed the title fix(ios): invoke event callbacks handling synchronously (8_0_X) fix(ios): delay js object creation to prevent accidental GC (8_0_X) Apr 12, 2019
vijaysingh-axway
vijaysingh-axway approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@ssjsamir ssjsamir self-requested a review May 7, 2019 14:10
ssjsamir
ssjsamir approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed, a reduction in crashes can be seen (e.g. against customer applications).

Test environment

iPhone 6S plus (12.2 Sim)
APPC CLI: 7.0.11-1
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.2.1

@lokeshchdhry lokeshchdhry merged commit af14065 into tidev:8_0_X May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@janvennemann @build @mukherjee2 @vijaysingh-axway @ssjsamir @lokeshchdhry @sgtcoolguy