Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): remove Ti.UI.currentWindow #10792

Merged
merged 3 commits into from Apr 3, 2019
Merged

fix(android)(8_0_X): remove Ti.UI.currentWindow #10792

merged 3 commits into from Apr 3, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.1 milestone Mar 21, 2019
@build build requested a review from a team March 21, 2019 21:41
@build
Copy link
Contributor

build commented Mar 21, 2019 •
edited

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.
📖 ❌ 1 tests have failed There are 1 tests failing and 450 skipped out of 3019 total tests.

Tests:

Classname Name Time Error
android.emulator.Titanium.Network.HTTPClient setCookieClearCookieWithMultipleHTTPClients 60.006 timeout of 60000ms exceeded

Generated by 🚫 dangerJS against 730bea5

sgtcoolguy
sgtcoolguy approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keerthi1032
Copy link
Contributor

FR Passed. Excueted TIMOB-4946 acceptance test which uses Ti.UI. current window getting undefined as expected.
Test Environment:
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Cli =7.0.10
studio =5.1.2.201903111843
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local 8.0.1.v20190321142528 and local master sdk 8.1.0.v20190321142031
Device =samsung s5 android 6
Emulator = PIXEL android8, nexus android 5
Target Platform = android

@sgtcoolguy sgtcoolguy merged commit 2557c6f into tidev:8_0_X Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @keerthi1032 @sgtcoolguy @drauggres