Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): Supported tel protocol similar to previous implementation #10793

Merged
merged 5 commits into from Apr 3, 2019
Merged

fix(ios): Supported tel protocol similar to previous implementation #10793

merged 5 commits into from Apr 3, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway added this to the 8.0.1 milestone Mar 21, 2019
@build build requested a review from a team March 21, 2019 22:41
@build
Copy link
Contributor

build commented Mar 21, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3633 tests are passing.

Generated by 🚫 dangerJS against fee4118

@janvennemann janvennemann modified the milestones: 8.0.1, 8.1.0 Mar 25, 2019
janvennemann
janvennemann previously requested changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the log message to explain that this a iOS only recommendation.

@sgtcoolguy sgtcoolguy dismissed janvennemann’s stale review April 1, 2019 18:48

Vijay addressed the feedback

@ssjsamir ssjsamir self-requested a review April 3, 2019 10:05
ssjsamir
ssjsamir approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Able to get call pop menu from a webView

Test Environment

iPhone 6 (12.1)
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit 9806a72 into tidev:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@janvennemann janvennemann janvennemann left review comments

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
8.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @janvennemann @ssjsamir @sgtcoolguy