Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default timeout value #10806

Merged
merged 2 commits into from Mar 27, 2019
Merged

Add default timeout value #10806

merged 2 commits into from Mar 27, 2019

Conversation

nicolomonili
Copy link
Contributor

@nicolomonili nicolomonili commented Mar 26, 2019

For iOS

JIRA: https://jira.appcelerator.org/browse/AC-6154

Provide a clear PR title prefixed with [TICKET]

Optional Description:

@build build added this to the 8.1.0 milestone Mar 26, 2019
@build build requested a review from a team March 26, 2019 10:03
@build
Copy link
Contributor

build commented Mar 26, 2019

Warnings
⚠️

🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

Messages
📖

🎊 Welcome to the Titanium SDK community, nicolomonili! Thank you so much for your PR, you're helping us make Titanium better. 🎁

Generated by 🚫 dangerJS against a5253b7

Revised wording of timeout
@sgtcoolguy
Copy link
Contributor

Thanks for the doc fix!

@sgtcoolguy sgtcoolguy merged commit 88aea61 into tidev:master Mar 27, 2019
@nicolomonili nicolomonili deleted the patch-1 branch March 28, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants