Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): remove hacky kroll-leftovers on app-termination #10812

Merged
merged 5 commits into from Apr 22, 2019

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Mar 28, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-26946

This was added 9 years ago here and does not cause issues with the JSCore / main-thread based architecture anymore.

Note: No new unit tests applicable, so requesting the no tests flag here.

@build build added this to the 8.1.0 milestone Mar 28, 2019
@build build requested a review from a team March 28, 2019 08:41
@build
Copy link
Contributor

build commented Mar 28, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

✅ All tests are passing
Nice one! All 3633 tests are passing.

Generated by 🚫 dangerJS against 31aace3

@build
Copy link
Contributor

build commented Apr 17, 2019

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

✅ All tests are passing
Nice one! All 3793 tests are passing.
(There are 466 tests skipped)

Generated by 🚫 dangerJS against bfb7f99

@keerthi1032
Copy link
Contributor

FR passed. Not showing last screen on relaunch ,App launched correctly after relaunching.
Test Environment:
Operating System
Name = Mac OS X
Version = 10.13.6
Node.js
Node.js Version = 8.9.1
npm Version = 5.5.1
Titanium CLI
CLI Version = 5.1.1
Studio =5.1.2.201903111843
Titanium SDK
SDK Version = local 8.1.0.v20190418111319 build
Device = iPhone 6s iOS 12, iPhone XS Max
Simulator = iPhone 6 iOS 12, iPhone 6s iOS 11
CLI=7.0.11-70X.1

@keerthi1032 keerthi1032 merged commit 96d2c16 into tidev:master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants