fix(ios): fix extension app group and entitlements support #10813
Conversation
|
| extBuildSettings.CODE_SIGN_ENTITLEMENTS = '"' + path.join(ext.relPath, targetName, entFile) + '"'; | ||
| targetInfo.entitlementsFile = path.join(this.buildDir, ext.relPath, targetName, entFile); | ||
| } else { | ||
| delete extBuildSettings.CODE_SIGN_ENTITLEMENTS; |
There was a problem hiding this comment.
I think we should spit out a warning here that we couldn't resolve the configured entitlements file instead of just silently deleting the CODE_SIGN_ENTITLEMENTS setting.
There was a problem hiding this comment.
That's what I originally thought too, but I realized that not every extension target has entitlements. For example, File Provider UI targets do not have entitlements. So, having a warning leads to false positives and that would be confusing.
There was a problem hiding this comment.
True, but wouldn't CODE_SIGN_ENTITLEMENTS then be empty anyway and we could check for that? Like an extra parameter if we should print a warning or not?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, so in that specific case it should be fine to print a warning, shouldn't it? If CODE_SIGN_ENTITLEMENTS is explicitly set, warn if we can't properly resolve it. If it's not set, e.g. for the File Provider UI extension, that code path is ignored anyway.
There was a problem hiding this comment.
I added a warning. Should be good to go now.
janvennemann
changed the title
…ITLEMENTS is not found.
|
FR Passed. App group showed and enabled correctly and entitlements files listed correctly. |
|
Danger is failing and not able to merge. can someone please resolve it |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26948
Fixes a typo where it was enabling the app group by setting
trueinstead of1.Also correctly reference the entitlements file, specifically when the entitlements is referenced by the
CODE_SIGN_ENTITLEMENTSbuild setting that is a relative path from the extension project's root.