fix(ios): fix extension app group and entitlements support (8_0_X) #10814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
janvennemann
changed the title
…ITLEMENTS is not found.
|
Awaiting @janvennemann 's approving review from #10813 |
janvennemann
approved these changes
Apr 2, 2019
|
FR Passed. App group showed and enabled correctly and entitlements files listed correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26948
Fixes a typo where it was enabling the app group by setting
trueinstead of1.Also correctly reference the entitlements file, specifically when the entitlements is referenced by the
CODE_SIGN_ENTITLEMENTSbuild setting that is a relative path from the extension project's root.