Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix for ‘target="_blank”’in html (8_0_X) #10839

Merged
merged 1 commit into from Apr 15, 2019
Merged

fix(ios): fix for ‘target="_blank”’in html (8_0_X) #10839

merged 1 commit into from Apr 15, 2019

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 8.0.1 milestone Apr 10, 2019
@build build requested a review from a team April 10, 2019 18:27
@build
Copy link
Contributor

build commented Apr 10, 2019

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 3023 tests are passing.

Generated by 🚫 dangerJS against c17f87d

@janvennemann janvennemann changed the title fix(ios): fix for ‘target="_blank”’in html fix(ios): fix for ‘target="_blank”’in html (8_0_X) Apr 11, 2019
@ssjsamir ssjsamir self-requested a review April 12, 2019 14:15
ssjsamir
ssjsamir approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Html having links with target="_blank" is now working tested with the following test case

var win = Ti.UI.createWindow({
backgroundColor: 'white'
});
var webview = Ti.UI.createWebView({
top: 60,
});
 
webview.setHtml("<!DOCTYPE html><html><body><p>Open link: <a href=\"https://www.google.com\" target=\"_blank\">click me</a></p></body></html>");
 
win.add(webview);
win.open();

Test Environment

iPhone 6S+ sim(12.1)
APPC CLI: 7.0.10
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.2
Node.js Version: 8.9.1
Xcode 10.1

@sgtcoolguy sgtcoolguy merged commit c865f13 into tidev:8_0_X Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@ssjsamir ssjsamir ssjsamir approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios needs tests 🚨
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @janvennemann @ssjsamir @sgtcoolguy