fix(ios): maintain native module proxies

[garymathews]

• Prevent native module proxies from being released when cached

TEST CASE

• Create Alloy project
• Use ACA 1.0.1

alloy.js

Alloy.Globals.aca =  = require('com.appcelerator.aca');
// should not crash

JIRA Ticket

[build]

	Warnings
⚠️	🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

Generated by 🚫 dangerJS against c8aad99

[vijaysingh-axway]

@garymathews I tried to run an app using sdk created with this code. It is giving following error -
`
[ERROR] Script Error {
[ERROR] column = 168;
[ERROR] line = 70;
[ERROR] message = "Can't find variable: regeneratorRuntime";
[ERROR] sourceURL = "file:///var/containers/Bundle/Application/222CF9EF-165B-402B-BE0F-5A67B4E55197/Lambus.app/login-manager.js";
[ERROR] stack = " at (/login-manager.js:70:168)\n at (/login-manager.js:150:231)\n at (/login-manager.js:382:421)\n at global code(/login-manager.js:383:70)\n at require@[native code]\n at require(/ti.internal/extensions/binding.js:24:118)\n at (/app.js:1:346)\n at global code(/app.js:224:70)\n at require@[native code]\n at require(/ti.internal/extensions/binding.js:24:118)\n at (/ti.main.js:40:8)\n at (/ti.internal/bootstrap.loader.js:157:9)\n at doLoad(/ti.internal/bootstrap.loader.js:139:9)\n at loadBootstrapScripts(/ti.internal/bootstrap.loader.js:151:7)\n at loadAsync(/ti.internal/bootstrap.loader.js:154:21)\n at global code(/ti.main.js:37:52)";
[ERROR] toJSON = "<KrollCallback: 0x281b379c0>";
[ERROR] }
[ERROR] Script Error Module "login-manager.js" failed to leave a valid exports object
[ERROR] Script Error Module "app.js" failed to leave a valid exports object

`

[garymathews]

@vijaysingh-axway Looks like that's to do with Babel

[vijaysingh-axway]

@garymathews But without this change it is working fine.

[garymathews]

@vijaysingh-axway Try it with the latest master build, because it looks like an issue with transpilation.

[vijaysingh-axway]

CR passed.

[hansemannn]

Is this save to be cherry picked? I'm not sure if this may cause a memory leak at some point. Protecting and unprotecting JSCore references is a pretty sensitive topic.

[vijaysingh-axway]

Backported it to 8_0_X. PR

[janvennemann]

This will never get called. A module/proxy only get's deallocated when JSCore will finalize a JSValueRef (i.e. when it's getting GC'd) and you actively prevent that by protecting the JSValueRef via rememberSelf. Basically the dealloc chain is: KrollFinalizer (triggered by JSCore GC) -> KrollObject dealloc -> TiProxy dealloc.

[janvennemann]

Since all native modules will be cached until the KrollBridge shuts down anyway it should be ok to remove the above lines and just stick with the rememberSelf.

[garymathews]

I'd like to keep the forgetSelf in dealloc since it could be possible to call dealloc on the KrollObject and there's no harm in keeping it it

[janvennemann]

You never send a dealloc manually, it will be done automatically though retain/release. And since the JS object retains the KrollObject there is no way that it will be called in a way that makes sense.

Sure there is no harm in keeping it, but i would prefer not having code around that has no effect ;)

Keeping forgetSelf in dealloc

[lokeshchdhry]

Not able to test the master PR due to https://jira.appcelerator.org/browse/TIMOB-27040. Will check it once its fixed.

[lokeshchdhry]

FR Passed.

Studio Ver: 5.1.2.201903111843
SDK Ver: 8.1.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.1
Appc NPM: 4.2.13
Appc CLI: 7.0.10
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.9
Node Ver: 8.15.1
NPM Ver: 6.4.1
Java Ver: 10.0.2
IOS Simulator: ⇨ iPhone XS (iOS 12.1)