feat(process): add initial implementations of setImmediate and process.nextTick #10863
Conversation
|
Follow-on to #10782 |
|
sgtcoolguy
force-pushed
the
process-timers
branch
from
4f715b3
to
b3e748f
Compare
| @@ -147,7 +147,9 @@ process.emitWarning = function (warning, options, code, ctor) { // eslint-disabl | |||
| } | |||
| this.emit('warning', warning); | |||
| }; | |||
| process.env = {}; | |||
| process.env = { | |||
| // DEBUG: '*' // uncomment to make use of npm 'debug' module. TODO: have CLI pass along env vars in some file/property for dev builds? | |||
There was a problem hiding this comment.
Would be pretty cool to pass environment settings! In our backend, we use https://github.com/motdotla/dotenv for handling environments. And for production builds, things like API keys could be managed by this.
There was a problem hiding this comment.
Ah, yeah that's a nice solution for production builds. Yeah I was trying to debug some low-level node-api compatibility issues in using mocha on our test suite and hacked in the process.env.DEBUG value here for it and then realized it'd be super-useful to hook our CLI up to generate some files that passed along the ENV for development builds so you could do DEBUG=* ti build -p ios and it just magically worked. I'll probably open a ticket and add that.
|
|
||
| // Use a nice predictable class/structure for our timers | ||
| // JS engine should be able to optimize easier | ||
| class Timer { |
There was a problem hiding this comment.
This name is a little misleading since it's not really a timer. It's a structure to hold a callback function and its arguments so something like BoundCallback would fit better IMHO.
In Node the object is called Immediate but since we use it for both setImmediate and nextTick that might cause confusion (although it's only used internally for nextTick).
| // Use a nice predictable class/structure for our timers | ||
| // JS engine should be able to optimize easier | ||
| class Timer { | ||
| constructor(fun, args) { |
There was a problem hiding this comment.
func is a more clear abbreviation here
| constructor(fun, args) { | |
| constructor(func, args) { |
|
manually merged after rebasing to single commit (and addressing Jan's feedback) |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26574
Description:
This is an implementation of
process.nextTick()and globalsetImmediate/clearImmediateI tested this usage in our mocha test suite with other node compatibility changes (some of the
fslibrary, modifiedrequire())The two implementations now do work in concert. ticks are drained fully in a while loop.
Immediatesare done afterwards with some caveats:Immediatesa 100ms window to process the queue. After that we basically exit the loop and use setTimeout to re-schedule processing the ticks/Immediatesremaining.Immediateis run. If so, we immediately drain the tick queue fully again before proceeding in our while loop to processImmediates(and again, the 100ms window limitation may cause us to not process any more immediate right now but do a setTimeout to re-schedule draining the queues)