New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26973] iOS: Add accessibilityIdentifier #10864
Conversation
For UI testing purposes compose "accessibilityIdentifier" property for views (same way it's done with "contentDescription" on Android). fix TIMOB-26973
refs TIMOB-26973
|
Hello, Is there an ETA of how long this PR will take to make it to production/next Titanium release (8.1.0?)? accessibility-id's are something our team has been needing for QA automation and we are looking forward to their addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drauggres Can you please document the properties? And please address two minor comments as well.
Can you give test case so that QE can verify this?
Thanks!
refs TIMOB-26973
var win = Ti.UI.createWindow({
backgroundColor: 'white',
layout: 'vertical'
});
function getHex() {
var a = (Math.random() * 256 | 0).toString(16);
if (a.length < 2) {
a = '0' + a;
}
return a;
}
function getRandomColor() {
return '#' + getHex() + getHex() + getHex();
}
var view1 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityLabel: 'view1Label',
height: 10,
width: Ti.UI.FILL
});
var view2 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityValue: 'view3Value',
height: 10,
width: Ti.UI.FILL
});
var view3 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityHint: 'view3Hint',
height: 10,
width: Ti.UI.FILL
});
var view4 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityLabel: 'view4Label',
accessibilityValue: 'view4Value',
height: 10,
width: Ti.UI.FILL
});
var view5 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityLabel: 'view5Label',
accessibilityHint: 'view5Hint',
height: 10,
width: Ti.UI.FILL
});
var view6 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityValue: 'view6Value',
accessibilityHint: 'view6Hint',
height: 10,
width: Ti.UI.FILL
});
var view7 = Ti.UI.createView({
backgroundColor: getRandomColor(),
accessibilityLabel: 'view7Label',
accessibilityValue: 'view7Value',
accessibilityHint: 'view7Hint',
height: 10,
width: Ti.UI.FILL
});
win.add(view1);
win.add(view2);
win.add(view3);
win.add(view4);
win.add(view5);
win.add(view6);
win.add(view7);
win.open(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drauggres There is one minor issue. Please fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR passed.
FR Passed. accessibility identifier is added. tested with test code provided in PR.works as expected Test Environment: |
can we get this back-ported to 7.5.X? |
https://jira.appcelerator.org/browse/TIMOB-26973
Compose
accessibilityIdentifier
for views on iOS the same waycontent description
is composed on Android.