fix(android)(8_0_X): Refactored activity/fragment restore handling #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [TIMOB-26966] Fixed bug where back navigating from child window causes app to exit when "Don't keep activities" is enabled as of 7.2.1. - [TIMOB-26914] Fixed 8.0.0 regression where an OS forced quit app displays a blank window upon relaunch. (Was incorrectly restoring child activity.) - [TIMOB-17089] Resolved view ID conflicts causes app crashes when activity/fragment is restored. - [TIMOB-26964] Fixed bug where TabGroup would be blank (no tabs) when calling child window's close() method while "Don't keep activities" is enabled. - [TIMOB-26890] Fixed bug where tapping 3rd tab in TabGroup can cause a crash due to view ID conflict during fragment restore. - Increased TabGroup's ViewPager offscreen page limit from 1 to 128 to avoid tab fragment from being destroyed/restored. - Added several safety mechanisms to AlertDialog and ProgressIndicator dialog code to avoid crashes.
…hin a fragment such as "ti.map" view - Re-added ID assigned to TiUIFragment's view, but it's now guaranteed to be assigned a unique ID.
…f "Don't keep activities" is enabled as of 8.0.0
- [TIMOB-15829] Fixed crash caused by progress indicator set to status bar that happens after hiding twice and then opening.
- [TIMOB-26966] Fixed bug where Window/TabGroup close()method call is ignored until "open" event has been fired. * Resolved by modifying proxy's handleClose() to call TiActivityWindows.remove() immediately. - Fixed bug where dynamically changing "exitOnClose" would be ignored. * Flag was only being read by activity's "launchIntent" in 8.0.0. * Now reads directly from proxy, which is the best solution. Especially if onNewIntent() was called. (Old code would have had a problem too.) - Re-added support for "exitOnClose" in child windows. (Was only supported by root window.) - Removed window exit animation if its "exitOnClose" was set true. (Prevents parent window briefly appearing upon exit.) - Added more dialog safe-guards. * Would crash if failed to create dialog builder if there are no activities available. * Can happen if "Don't keep activities" is enabled, you press the Home button, and code attempts to show dialog in the background.
… after OS force quit it
|
|
FR Passed. The activity/fragment refactor looks good. Studio Ver: 5.1.2.201903111843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Cherry-pick of:
PR #10829